Bogus Warning in ppp_generic.c

From: Norbert Wolff (norbert_wolff@t-online.de)
Date: Fri May 09 2003 - 03:24:01 EST

Hi !

If devfs is not configured, devfs_mk_cdev returns 0.
The ppp_generic-Driver reports a bogus Warning in this case.
Fix below.

Regards,

        Norbert

--- ppp_generic.c.orig 2003-05-09 09:16:56.%N +0200
+++ ppp_generic.c 2003-05-09 10:09:19.%N +0200
@@ -784,10 +784,13 @@ int __init ppp_init(void)
 
         printk(KERN_INFO "PPP generic driver version " PPP_VERSION "\n");
         err = register_chrdev(PPP_MAJOR, "ppp", &ppp_device_fops);
+
+#ifdef CONFIG_DEVFS_FS
         if (!err) {
                 err = devfs_mk_cdev(MKDEV(PPP_MAJOR, 0),
                                 S_IFCHR|S_IRUSR|S_IWUSR, "ppp");
         }
+#endif
 
         if (!err)
                 printk(KERN_ERR "failed to register PPP device (%d)\n", err); 

--
 Norbert Wolff
 OpenPGP-Key:
   http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xF13BD6F6
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:30 EST