Re: [PATCH][ATM] make clip modular

From: David S. Miller (davem@redhat.com)
Date: Mon May 12 2003 - 15:26:41 EST


   From: chas williams <chas@locutus.cmf.nrl.navy.mil>
   Date: Mon, 12 May 2003 17:26:04 -0400

   how about this for now for clip (lane et al will come later):
   
Still buggy.

...

   -#ifdef CONFIG_ATM_CLIP
   +#if defined(CONFIG_ATM_CLIP) || defined(CONFIG_ATM_CLIP_MODULE)
                    case SIOCMKCLIP:
                            if (!capable(CAP_NET_ADMIN))
                                    ret_val = -EPERM;
                            else
   - ret_val = clip_create(arg);
   + ret_val = atm_clip_ops->clip_create(arg);
                            goto done;

Do you know that atm_clip_ops is non-NULL here? How is that?

Also how can you legally call into a module without having a reference
to it or somehow otherwise blocking it's unloading (f.e. by holding
the ops semaphore)?

Chas, please think carefully about this problem.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:41 EST