Re: [PATCH][ATM] add reference counting to atm_dev

From: Greg KH (greg@kroah.com)
Date: Wed May 14 2003 - 16:57:04 EST


On Wed, May 14, 2003 at 02:02:57PM -0700, David S. Miller wrote:
> From: Greg KH <greg@kroah.com>
> Date: Wed, 14 May 2003 13:59:49 -0700
>
> Any reason to not just use a struct device here? This is a device,
> right? Or at the very least, a kobject would be acceptable.
>
> As I understand it, it's a device private for a struct netdevice.

Ah, thanks.

> It is referenced much differently, I don't think using kobject
> is as appropriate as one might expect.

kobjects are always appropriate! :)

Remember, you don't have to use the sysfs part of a kobject to get the
reference counting and callback when the last reference is dropped
goodness. A few places in the kernel use them in this manner only,
that's what it was created for.

Ok, if they aren't needed here, I have no problem, just wanted to make
sure.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 15 2003 - 22:00:54 EST