Re: arch/i386/kernel/mpparse.c warning fixes

From: mikpe@csd.uu.se
Date: Thu May 22 2003 - 11:07:43 EST


William Lee Irwin III writes:
> diff -prauN mm8-2.5.69-1/arch/i386/kernel/mpparse.c mm8-2.5.69-2/arch/i386/kernel/mpparse.c
> --- mm8-2.5.69-1/arch/i386/kernel/mpparse.c 2003-05-22 04:54:48.000000000 -0700
> +++ mm8-2.5.69-2/arch/i386/kernel/mpparse.c 2003-05-22 08:06:13.000000000 -0700
> @@ -171,7 +171,7 @@ void __init MP_processor_info (struct mp
>
> num_processors++;
>
> - if (m->mpc_apicid > MAX_APICS) {
> + if (MAX_APICS - m->mpc_apicid <= 0) {
> printk(KERN_WARNING "Processor #%d INVALID. (Max ID: %d).\n",
> m->mpc_apicid, MAX_APICS);
> --num_processors;

Eeew. Whatever the original problem is, this "fix" is just too obscure and ugly.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:49 EST