Re: Properly implement flush_dcache_page in 2.4? (Or is it possible?)

From: Russell King (rmk@arm.linux.org.uk)
Date: Sat May 31 2003 - 02:56:18 EST


On Sat, May 31, 2003 at 08:24:00AM +0100, Hugh Dickins wrote:
> On Sat, 31 May 2003, Russell King wrote:
> >
> > I don't see a reason to worry about privately mapped pages on the i_mmap
> > list since they are private, and therefore shouldn't be updated with
> > modifications to other mappings, which I'd have thought would include
> > writes to the file (although I'm not so sure atm.)
>
> Be not so sure. vmas on the private i_mmap list can still contain
> shared pages, which should see writes to the file; but of course their
> already-COWed private pages won't see subsequent writes to the file.

Hmm, looking at the posix spec (do we follow POSIX for mmap?) the
behaviour of MAP_PRIVATE mappings when the underlying file is modified
is unspecified.

I guess missing the cache handling for such mappings fits the POSIX
spec, and is equally as yucky as the current behaviour on CPUs which
don't require these flushes.

(unless someone tells me that POSIX is on drugs, I'm not going to be
that bothered about the MAP_PRIVATE case.)

--
Russell King (rmk@xxxxxxxxxxxxxxxx) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/