Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS

• Next message: Tim Connors: "Re: [PATCH] 2.4 laptop mode"
• Previous message: Andreas Hartmann: "[2.4.17rc7] broken IO-APIC support with MPS 1.4"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <Pine.SOL.4.30.0306071815120.6449-100000@mion.elka.pw.edu.pl> you write:
> -static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
> +#define remove_proc_entry(name, parent) /* nothing */

> And you wil not have to readd #ifdef/#endif pair.
>
> I've seen Sam's mail but this is generic solution to quiet compiler
> and will work for any remove_proc_entry() user.

And it'll leave unused warnings all over the place, meaning you have
to add __unused to all the callers. Now gcc 3.3 will actually discard
those unused functions, this might be worth considering.

But if you're going to do that, make create_proc_entry etc *not*
return NULL if !CONFIG_PROC_FS, otherwise you need the #ifdef anyway.
This has been noted before.

Good luck!
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Tim Connors: "Re: [PATCH] 2.4 laptop mode"
• Previous message: Andreas Hartmann: "[2.4.17rc7] broken IO-APIC support with MPS 1.4"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:19 EST