Re: [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note

From: DervishD (raul@pleyades.net)
Date: Mon Jun 16 2003 - 07:58:07 EST


    Hi Jörn :)

 * Jörn Engel <joern@wohnheim.fh-wedel.de> dixit:
> > There is a change in archs where TASK_SIZE is the entire
> > addressable space (like sparc64). Ask Dave S., again. The problem did
> > arise when TASK_SIZE is ~0. Then semantics change.
> True. PAGE_ALIGN(-1) = 0 and that case would not get caught with the
> old code. Looks good to me.

    This was pointed to me by Dave. I prepared a patch time ago just
for the case where 'len' was quite large, but I assumed that
TASK_SIZE was at least one less page than the entire addressable
space, which is not true. My fault O:))

    Thanks for pointing, anyway.

> Public Domain - Free as in Beer
> General Public - Free as in Speech
> BSD License - Free as in Enterprise
> Shared Source - Free as in "Work will make you..."

    Good one ;))))

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736
http://www.pleyades.net & http://raul.pleyades.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:18 EST