"Stephen C. Tweedie" <sct@redhat.com> wrote:
>
> Hi,
>
> On Sun, 2003-06-15 at 12:01, Roy Sigurd Karlsbakk wrote:
> > hi all
> >
> > I've been waiting for the official O_DIRECT on ext3 for some time now, so I
> > thought perhaps it's time to get it into 2.4.22 or so. The patch I've used, is
> > the one below (for 2.4.21):
>
> This is Andrea's patch,
Actually I'm the culprit.
> (like allowing direct IO in journaled data mode --- bad move ---
hmm, OK, it doesn't even vaguely work in journalled mode either...
I think the check should be implemented in (the new) ext3_open(). Because
checking the return from open() is the way in which a good application would
determine whether the underlying fs supports O_DIRECT.
Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
have forgotten to provide a way for the fs to be told about fcntl.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:22 EST