Re: [PATCH] PCI direct access resources

From: Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz@elka.pw.edu.pl)
Date: Fri Jun 20 2003 - 11:46:17 EST

Next message: Arnaud Ligot: "Re: xircom card bus with 2.4.20 link trouble"
Previous message: Steven Pratt: "Re: ext3 umount hangs"
In reply to: Matthew Wilcox: "[PATCH] PCI direct access resources"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 20 Jun 2003, Matthew Wilcox wrote:

> + if (!pci_probe & PCI_PROBE_CONF1)
> + goto type2;

(!pci_probe & PCI_PROBE_CONF1) will be always FALSE if pci_probe != 0,
correct check is:

if ((pci_probe & PCI_PROBE_CONF1) == 0)

> + if (!pci_probe & PCI_PROBE_CONF2)
> + goto out;

Same comment here.

-- Bartlomiej

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Arnaud Ligot: "Re: xircom card bus with 2.4.20 link trouble"
Previous message: Steven Pratt: "Re: ext3 umount hangs"
In reply to: Matthew Wilcox: "[PATCH] PCI direct access resources"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:33 EST