Re: [PATCH] page cache readahead implemented?

From: Andrew Morton (akpm@digeo.com)
Date: Sun Jun 22 2003 - 18:04:31 EST


Hugh Dickins <hugh@veritas.com> wrote:
>
> On Sun, 22 Jun 2003, Andrew Morton wrote:
> > Hugh Dickins <hugh@veritas.com> wrote:
> > >
> > > do_mmap_pgoff's PROT_EXEC do_page_cache_readahead assumes that is
> > > implemented for all mappings, but not all filesystems provide ->readpage.
> >
> > Which filesystems?
>
> No prize for guessing it was tmpfs I found the problem with.

Yeah, the usual blot on the kernelscape.

> Am I reading alloc_inode correctly, that the default it gives is
> an empty_aops with NULL readpage, but a backing_dev_info with non-0
> ra_pages? How does your do_mmap_pgoff fare on a PROT_EXEC mapping
> of one of those mmaping device drivers?

Probably explodes? I'm not particularly serious about that change - it
can be done in userspace.

Is the do_mmap_pgoff() hack the only offender? If so it would be better to
localise the test in there too.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:39 EST