Re: [dm-devel] Re: [RFC 3/3] dm: v4 ioctl interface

From: Joe Thornber (thornber@sistina.com)
Date: Wed Jul 02 2003 - 06:00:44 EST


dm_swap_table() will now fail for a table with no targets.
--- diff/drivers/md/dm.c 2003-07-01 15:36:42.000000000 +0100
+++ source/drivers/md/dm.c 2003-07-02 11:53:22.000000000 +0100
@@ -664,10 +664,10 @@
         md->map = t;
 
         size = dm_table_get_size(t);
- set_capacity(md->disk, size);
- if (size == 0)
- return 0;
+ if (!size)
+ return -EINVAL;
 
+ set_capacity(md->disk, size);
         dm_table_event_callback(md->map, event_callback, md);
 
         dm_table_get(t);
@@ -759,8 +759,10 @@
 
         __unbind(md);
         r = __bind(md, table);
- if (r)
+ if (r) {
+ up_write(&md->lock);
                 return r;
+ }
 
         up_write(&md->lock);
         return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 07 2003 - 22:00:15 EST