[2.6 patch] ISDN PCBIT: #ifdef MODULE some code

• Next message: Steven Newbury: "SCHED_SOFTRR patch"
• Previous message: Alan Cox: "RE: DMA not supported with Intel ICH4 I/O controller?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I got the following error at the final linkage of 2.6.0-test2 if
CONFIG_ISDN_DRV_PCBIT is compiled statically:

<-- snip -->

...
  LD .tmp_vmlinux1
...
drivers/built-in.o(.exit.text+0xe183): In function `pcbit_exit':
: undefined reference to `pcbit_terminate'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

I don't know whether the following patch is the best solution, but it
solves the problem:

--- linux-2.6.0-test2-full-no-smp/drivers/isdn/pcbit/module.c.tmp 2003-07-28 22:03:38.000000000 +0200
+++ linux-2.6.0-test2-full-no-smp/drivers/isdn/pcbit/module.c 2003-07-28 22:08:57.000000000 +0200
@@ -82,12 +82,14 @@
 
 static void __exit pcbit_exit(void)
 {
+#ifdef MODULE
         int board;
 
         for (board = 0; board < num_boards; board++)
                 pcbit_terminate(board);
         printk(KERN_NOTICE
                "PCBIT-D module unloaded\n");
+#endif
 }
 
 #ifndef MODULE

cu
Adrian

-- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Steven Newbury: "SCHED_SOFTRR patch"
• Previous message: Alan Cox: "RE: DMA not supported with Intel ICH4 I/O controller?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:37 EST