Re: [PM] suspend.c cleanups

From: Pavel Machek (pavel@ucw.cz)
Date: Tue Aug 05 2003 - 04:15:29 EST


Hi!

> > -#define TEST_SWSUSP 0 /* Set to 1 to reboot instead of halt machine after suspension */
> > +#define TEST_SWSUSP 1 /* Set to 1 to reboot instead of halt machine after suspension */
>
> This is not a cleanup, it changes behavior, so I didn't apply this first
> part (since I had to make the other changes by hand anyway).

Sorry for that.

> > @@ -906,7 +898,7 @@
> > return;
> >
> > software_suspend_enabled = 0;
> > - BUG_ON(in_interrupt());
> > + BUG_ON(in_atomic());
> > do_software_suspend();
> > }
>
> I replaced the BUG() with might_sleep(), since it will produce a stack
> trace, and is a bit friendlier.

Yes, thats better.
                                                        Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:28 EST