Re: [PATCH] Export touch_nmi_watchdog

From: Andi Kleen (ak@colin2.muc.de)
Date: Tue Aug 05 2003 - 15:08:10 EST


On Tue, Aug 05, 2003 at 12:38:11PM -0700, Andrew Morton wrote:
> Andi Kleen <ak@muc.de> wrote:
> >
> > Sometimes drivers do long things with interrupt off and the NMI watchdog
> > triggers quickly. This mostly happens in error handling. It would be
> > better to fix the drivers to sleep in this case, but it's not always
> > possible or too much work.
>
> yup.
>
> Do we need an mdelay_while_touching_nmi_watchdog() variant?

Maybe that would be too encoraging for broken code.

Admittedly I did that by hand for the MPT fusion driver (which currently
triggers the watchdog when it gets into any error handling situation)
This especially hurts on x86-64 which runs the watchdog by default.
But it's strictly a bad hack, not a good interface.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:30 EST