Re: [PATCH 2.6] ToPIC specific init for yenta_socket

From: Pavel Roskin (proski@gnu.org)
Date: Wed Aug 06 2003 - 14:07:21 EST


On Wed, 6 Aug 2003, Russell King wrote:

> On Wed, Aug 06, 2003 at 08:25:08PM +0200, Daniel Ritz wrote:
> > this patch adds override functions for the ToPIC family of controllers.
> > also adds the device id for ToPIC100 and (untested) support for zoom
> > video for ToPIC97/100.
> >
> > tested with start/stop and suspend/resume.
>
> We currently have some fairly serious IRQ problems with yenta at the
> moment. I'm holding all patches until we get this problem resolved -
> it seems to be caused by several bad changes over the past couple of
> years accumulating throughout the 2.5 series.

I read the PCMCIA list, but not LKML, and I have no idea what problems you
are talking about. Could you please explain of give a pointer to a
previous post? I could cross-check the problem against plx9052 driver.

I'm sorry for asking you to spend some time and possibly repeat something
that was said before, but sometimes talking about the problem makes it
easier to understand it and find the best solution.

> Also, assigning to socket->socket.ops->init modifies the global
> yenta_socket_operations structure, which I'm far from happy about.

The same is done for TI and Ricoh bridges. Just search the sources for
"socket->socket.ops->init". You may have a good reason to be unhappy, but
coherent code is normally easier to fix than a bunch of different hacks.

-- 
Regards,
Pavel Roskin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:34 EST