Re: [PATCH] [2.6.0-test3] request_firmware related problems.

From: Manuel Estrada Sainz
Date: Sun Aug 10 2003 - 17:04:40 EST


On Sun, Aug 10, 2003 at 02:29:28PM -0700, Andrew Morton wrote:
> Manuel Estrada Sainz <ranty@xxxxxxxxxx> wrote:
> >
> > Please apply the following patches.
>
> Please, send just one patch per email, each one having its own changelog
> info. There's just no way anyone's patch import tools can handle a single
> changelog and multiple attachments. It is painful.

Sorry, I'll do it in a few minutes.

> > - request_firmware_own-workqueue.diff:
> > - In it's current form request_firmware_async() sleeps way too
> > long on the system's shared workqueue, which makes it
> > unresponsive until the firmware load finishes, gets canceled
> > or times out.
>
> Does this mean that we have another gaggle of kernel threads for all the
> time the system is up?

I guess so.

> It might be better to create a custom kernel thread on-demand, or kill off
> the workqueue when its job has completed.

OK, I'll wait on this one, and think about it, after all, it just fixes
annoying behavior, not real breakness.

Thanks for the quick reply

Manuel

--
--- Manuel Estrada Sainz <ranty@xxxxxxxxxx>
<ranty@xxxxxxxxxxx>
<ranty@xxxxxxxxxxxxxxxxxxxxx>
------------------------ <manuel.estrada@xxxxxxxxxxxxx> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/