Re: [PATCH] kernel/futex.c: Uneeded memory barrier

[Jamie Lokier]

The patch looks fine to me.

Felipe W Damasio wrote:
> 	Kills an unneeded set_current_state after schedule_timeout, since it 
> already guarantees that the task will be TASK_RUNNING.
> 
> 	Also, when setting the state to TASK_RUNNING, isn't that memory 
> barrier unneeded? Patch removes this memory barrier too.

If _all_ instances in the kernel of

	set_current_state(TASK_RUNNING)

can be validly turned into

	__set_current_state(TASK_RUNNING)

it would be good to make the barrier in set_current_state() itself
conditional on the state being state.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/