Re: 2.6.0-test9: selinux compile error with "make O=..."

[Sam Ravnborg]

On Sun, Oct 26, 2003 at 02:22:09AM +0200, Adrian Bunk wrote:
> The problem comes from the following line in 
> security/selinux/ss/Makefile:
>   EXTRA_CFLAGS += -Isecurity/selinux/include -include security/selinux/ss/global.h

Hi Adrian.
Known problem that has been reported back to the maintainers about
one month ago. But they do not seem to care enough to fix it.

The use of "-include" is a bad way to include files. The reader will
not see that global.h is included at all and will wonder how that
information get pulled in.

Furhtermore the location of the header files under security/include
is considered bad practice. All headerfiles used from more than one
directory belongs to include/xxx, in this case include/security.
Then they can be included using
#include <security/secuity.h>

Everything are post 2.6.0 material.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/