[PATCH 2.4.23-pre8] ieee1394 nodemgr deadlock

From: Stelian Pop
Date: Sun Oct 26 2003 - 11:51:12 EST


Hi,

This patch was submitted here a while ago, has been ack'ed by
Ben Collins but it still hasn't made it into the 2.4 tree.

Marcelo, please apply it, without this patch kudzu deadlocks
on every boot on my RedHat laptop.

Thanks,

Stelian.

===== drivers/ieee1394/nodemgr.c 1.23 vs edited =====
--- 1.23/drivers/ieee1394/nodemgr.c Sat Jul 19 18:11:56 2003
+++ edited/drivers/ieee1394/nodemgr.c Mon Sep 29 10:31:17 2003
@@ -1317,8 +1317,10 @@
* to make sure things settle down. */
for (i = 0; i < 4 ; i++) {
set_current_state(TASK_INTERRUPTIBLE);
- if (schedule_timeout(HZ/16))
+ if (schedule_timeout(HZ/16)) {
+ up(&nodemgr_serialize);
goto caught_signal;
+ }

/* Now get the generation in which the node ID's we collect
* are valid. During the bus scan we will use this generation
--
Stelian Pop <stelian@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/