Re: [2.6.0-test8/9] ethertap oops

From: David S. Miller
Date: Mon Oct 27 2003 - 02:55:52 EST


On Sun, 26 Oct 2003 23:45:52 +0100
Andi Kleen <ak@xxxxxx> wrote:

> diff -u linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o linux-2.6.0test7mm1-averell/drivers/net/ethertap.c
> --- linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o 2003-09-11 04:12:33.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/drivers/net/ethertap.c 2003-10-26 23:41:17.000000000 +0100

This part looks good, applied.

> diff -u linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c
> --- linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o 2003-10-09 00:29:02.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c 2003-10-26 23:42:44.000000000 +0100
> @@ -777,6 +777,7 @@
> if (input)
> nlk_sk(sk)->data_ready = input;
>
> + sk->sk_protocol = unit;
> netlink_insert(sk, 0);
> return sk;
> }

This part is not needed, netlink_create() does this for us :-)

Thanks Andi.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/