Re: ACPI PM-Timer [Was: Re: [RFC][PATCH] must fix lists]

[john stultz]

On Mon, 2003-10-27 at 10:49, Dominik Brodowski wrote:
> On Mon, Oct 27, 2003 at 10:42:34AM -0800, john stultz wrote:
> > My only comment is that rather then replacing the time source midstream,
> > could we not do as the HPET time source does and use the late_time_init
> > callback? That avoids the nasty time source switching code. 
> 
> Because "late_time_init" is way too early. It might be usable for the
> (unimplemented) detection method c) -- parsing the ACPI FADT ourselves --
> described in the timer_pm.c code.
> However, the currently used method uses struct acpi_fadt which is
> filled in drivers/acpi/bus.c:acpi_bus_init(), which is called from 
> a subsys_initcall.


Ah, OK. Well, I'd prefer the manual ACPI parsing personally, but having
tried and failed to implement it once myself, I'd more prefer not to do
it myself. ;)

Let me get your patches up and running and I'll see if I have any
reasonable feedback. 

Thanks again!
-john


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/