Re: [PATCH] Prevent PCI driver registration failure oopsing

From: Greg KH
Date: Wed Oct 29 2003 - 18:32:43 EST


On Tue, Oct 28, 2003 at 10:51:26AM +0000, Russell King wrote:
> On Tue, Oct 28, 2003 at 11:48:05AM +0100, Andreas Schwab wrote:
> > Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> writes:
> > > + return rc < 0 ? : 0;
> >
> > Are you sure you want to return 1 if rc < 0?
>
> Argh. Definitely not. Thanks for spotting that.
>
> --- orig/include/linux/pci.h Thu Mar 13 14:24:56 2003
> +++ linux/include/linux/pci.h Wed Mar 12 19:37:41 2003

Thanks, I've applied this and will send it to Linus when 2.6.0 is out.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/