Re: [patch] reproducible athlon mce fix

[Zwane Mwaikambo]

On Sun, 2 Nov 2003, Willy Tarreau wrote:

> 1) a still readable one
> #if CONFIG_MK7
> 	i=1;
> #else
>  	i=0;
> #endif
>  	for (; i<nr_mce_banks; i++) {
> 
> 2) when there's absolutely no choice (eg changing part of an
>    expression...) something unreadable like this.
> 
> 	for (
> #if CONFIG_MK7
> 	i=1;
> #else
>  	i=0;
> #endif
>  	i<nr_mce_banks; i++) {
> 
> I'm sure other people have other solution that don't come to mind.

Perhaps..

#ifdef CONFIG_MK7
#define MCE_BANK_START	1
#else
#define MCE_BANK_START	0
#endif

for (i = MCE_BANK_START; nr_mce_banks; i++)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/