Re: [PATCH] SMP signal latency fix up.

[Chris Friesen]

Mark Gross wrote:

> diff -urN -X dontdiff linux-2.6.0-test9/kernel/sched.c /opt/linux-2.6.0-test9/kernel/sched.c
> --- linux-2.6.0-test9/kernel/sched.c    2003-10-25 11:44:29.000000000 -0700
> +++ /opt/linux-2.6.0-test9/kernel/sched.c       2003-11-06 13:04:03.628116240 -0800
> @@ -626,13 +626,13 @@
>                         }
>                         success = 1;
>                 }
> -#ifdef CONFIG_SMP
> -               else
> -                       if (unlikely(kick) && task_running(rq, p) && (task_cpu(p) != smp_processor_id()))
> -                               smp_send_reschedule(task_cpu(p));
> -#endif
>                 p->state = TASK_RUNNING;
>         }
> +#ifdef CONFIG_SMP
> +               else
> +               if (unlikely(kick) && task_running(rq, p) && (task_cpu(p) != smp_processor_id()))
> +                       smp_send_reschedule(task_cpu(p));
> +#endif
>         task_rq_unlock(rq, &flags);

Without any comment as to whether or not the patch would work, shouldn't 
the "else" be moved back by a tab?

Chris




--
Chris Friesen                    | MailStop: 043/33/F10
Nortel Networks                  | work: (613) 765-0557
3500 Carling Avenue              | fax:  (613) 765-2986
Nepean, ON K2H 8E9 Canada        | email: cfriesen@xxxxxxxxxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/