Re: [PATCH] FIx 'noexec' behavior

[Jon Smirl]

This seems to fix it:

[jonsmirl@smirl mm]$ bk diffs
===== mmap.c 1.94 vs edited =====
481c481
<       if ((prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXEC))
---
>       if (file && (prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXE
C))
[jonsmirl@smirl mm]$

Although I didn't have any oops on my console, in dmesg or messages.


--- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:
> Ulrich Drepper <drepper@xxxxxxxxxx> writes:
> 
> 	if (file && (!file->f_op || !file->f_op->mmap))
> 		return -ENODEV;
> 
> 	if ((prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXEC))
> 		return -EPERM;
> 
> Probably he get the oops, because file can be NULL.
> -- 
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>


=====
Jon Smirl
jonsmirl@xxxxxxxxx

__________________________________
Do you Yahoo!?
New Yahoo! Photos - easier uploading and sharing.
http://photos.yahoo.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/