Re: [linux-usb-devel] Re: [OOPS, usbcore, releaseintf] 2.6.0-test10-mm1

[Duncan Sands]

> That leads to the question of how to assure that the device doesn't go
> away before usb_set_configuration is called.  Perhaps
> usb_set_configuration and usb_unbind_interface should be changed to
> require the caller to hold the serialize lock.

How about

__usb_set_configuration - lockless version
usb_set_configuration - locked version

?

By the way, here is the list of routines that cause trouble for usbfs:

usb_probe_interface
usb_reset_device
usb_set_configuration
usb_unbind_interface

Both usb_set_configuration and usb_unbind_interface can be trivially
modified to have a __ form.  usb_probe_interface and usb_reset_device
require thought.

All the best,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/