Re: [PATCH] rearrange cpumask.h headers in conventional structure

From: Andrew Morton
Date: Mon Dec 15 2003 - 12:04:24 EST


Paul Jackson <pj@xxxxxxx> wrote:
>
> ...
> The convention for any facility that is partially generic,
> partially arch specific is for each include/asm-* arch to
> have it's own arch-specific header file (picked up via the
> include/asm symlink to the current arch), and for those
> arch-specific header files in turn to include asm-generic
> headers, if and to the extend that they choose to make use of
> the generic implementation.
>
> ...
> -#include <linux/cpumask.h>
> +#include <asm/cpumask.h>

Personally, I rather prefer that include/linux/cpumask.h be retained, and
that it perform the inclusion of <asm/cpumask.h>. This provides some level
of information hiding and gives us somewhere to place cpumask things which
we _know_ are arch-independent.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/