Re: [PATCH 3/5] 2.6.0 sched migrate comment

[Nick Piggin]

Ingo Molnar wrote:

> * Nick Piggin <piggin@xxxxxxxxxxxxxxx> wrote:
>
>  
>
> > Some comments were lost during minor surgery here...
> >    
>
> this patch collides with John Hawkes' sched_clock() fix-patch which goes
> in first. Also, the patch does more than just comment fixups. It changes
> the order of tests, where a bug slipped in:
>
> +       if (!idle && (delta <= cache_decay_ticks))
>
> This will cause the cache-hot test to almost never trigger, which is
> clearly incorrect. The correct test is:
>
>        if (!idle && (delta <= JIFFIES_TO_NS(cache_decay_ticks)))
>
> anyway, i've fixed it all up (patch attached).
>  

Yep, thanks again.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/