Re: [PATCH] seq_file version of /proc/interrupts

[Anton Blanchard]

Hi Jon,

> Here, anyway, is a better version of the patch.  It's less intrusive,
> forgoes some "cleanups" I indulged in the first time, and makes it easier
> to update other architectures.  I did x86-64, ia_64 and ppc64 just for the
> heck of it, but I can't test them.

We finally got around to testing it on ppc64. Looks good, only one problem:

diff -urN -X dontdiff test9-vanilla/arch/ppc64/kernel/irq.c test9/arch/ppc64/kernel/irq.c
--- test9-vanilla/arch/ppc64/kernel/irq.c	Tue Oct 21 04:40:13 2003
+++ test9/arch/ppc64/kernel/irq.c	Fri Nov 14 05:10:02 2003
@@ -323,18 +323,20 @@
 
 int show_interrupts(struct seq_file *p, void *v)
 {
-	int i, j;
+	int i = *(int *) v, j;
 	struct irqaction * action;
 	unsigned long flags;

That int * has to be a loff_t * or bad things will happen on a 64bit big
endian platform :)

Be nice to chuck this into -mm for some more testing.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/