Re: [PATCH 1/2] Add dm-daemon

From: Christoph Hellwig
Date: Tue Dec 23 2003 - 07:32:11 EST


On Mon, Dec 22, 2003 at 10:49:52PM +0100, Christophe Saout wrote:
> Hi.
>
> The first patch adds dm-daemon.c/.h.
>
> The code is from Joe Thornbers current unstable device-mapper patchset.

This should really be in generic code, not in DM. I remember I did
something similar as kthread abstraction a while ago, but it didn't head
anywhere..

> diff -Nur linux-2.6.0.orig/drivers/md/dm.h linux-2.6.0/drivers/md/dm.h
> --- linux-2.6.0.orig/drivers/md/dm.h 2003-11-24 02:31:53.000000000 +0100
> +++ linux-2.6.0/drivers/md/dm.h 2003-12-22 17:56:05.000000000 +0100
> @@ -20,6 +20,12 @@
> #define DMINFO(f, x...) printk(KERN_INFO DM_NAME ": " f "\n" , ## x)
>
> /*
> + * FIXME: There must be a better place for this.
> + */
> +typedef typeof(jiffies) jiffy_t;

Eeek..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/