Re: no DRQ after issuing WRITE was Re: 2.4.23-uv3 patch set released

[Linus Torvalds]

On Tue, 30 Dec 2003, Marcelo Tosatti wrote:
> 
> Small correction: people are not hitting the WAIT_READY (they are hitting
> the problem from ide-disk.c, which uses WAIT_DRQ). But still...

Ok. Do you have the full trace? In particular, if there is no locking in 
that path, and interrupts are enabled, you could possibly get not just an 
interrupt, but a preemption event. Now _that_ could blow up the timeout to 
any amount of time, and then even 100ms might not be enough.

Is CONFIG_PREEMPT on in the cases, and is there really no locking 
anywhere? Preempting in the middle of the data transfer phase sounds like 
a fundamentally bad idea, and maybe the code needs a few preempt 
disable/enable pairs somewhere?

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/