Re: System hangs after echo value > /sys/block/dm-0/queue/nr_requests

[Jens Axboe]

On Tue, Dec 30 2003, Mike Christie wrote:
> Andrew Morton wrote:
> 
> >Where queue_requests_store() does wake_up(&rl->wait[READ]);
> >
> >It looks like nobody has called blk_init_queue() for this queue and the
> >waitqueue head is uninitialised.
> >
> 
> DM, MD, rd and loop use blk_alloc_queue and blk_queue_make_request to 
> initialize their queue, because they only use the make_request_fn. The 
> attached patch prevents the queue from being registered if only 
> blk_alloc_queue was called.

I'm fine with that patch since we don't have any attributes in there
that apply to just remappers.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/