Re: [PATCH] "gconfig" removed root folder...

[Tomas Szepe]

On Jan-17 2004, Sat, 22:47 +0100
Romain Lievin <romain@xxxxxxxxxxxxxxxxxx> wrote:

> > On Jan-15 2004, Thu, 22:44 +0100
> > Romain Lievin <romain@xxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > +	if(stat(fn, &sb) == -1) return;	
> > 
> > Codingstyle inconsistency.
> 
> What should I write then ? Your piece of advice may make me better.

Read Documentation/CodingStyle.  It is loosely based on the original
K&R style, where (the scarce) language constructs' arguments' opening
parenthese is prepended by a space, whereas with functions and macros
it is not.  I.e., one writes 'if (...)', 'while (...)', 'foo(bar)', etc.

Also, your explicit casts could use extra whitespace, like so:
"a = (int *) b;" not "a = (int *)b;"

When submiting code to an existing file, the general rule of thumb
is not to disrupt the style of that particular file, regardless
of what it appears to be.  You have managed to break this rule
_and_ the official CodingStyle.

-- 
Tomas Szepe <szepe@xxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/