Re: limit-timer_pm-printk-storms.patch

[john stultz]

On Tue, 2004-01-20 at 11:57, Andrew Morton wrote:
> Bongani Hlope <bonganilinux@xxxxxxxxxx> wrote:
> >
> > This patch has been inspired by the limit-IO-error-printk-storms patch. On my PII when I enable 
> > CONFIG_X86_PM_TIMER this gets called a lot of times, I guess my VIA chipset is too broken to play with this.
> > 
> > <example>
> > ...
> > Jan 19 04:21:46 bongani kernel: bad pmtmr read: (15567390, 15567423, 15567393)
> > Jan 19 04:21:46 bongani kernel: bad pmtmr read: (1746710, 1746719, 1746713)
> > Jan 19 04:21:47 bongani kernel: bad pmtmr read: (2239982, 2239999, 2239986)
> 
> Does the PM timer actually do the right thing once these printk's are
> suppressed?

Yep, as I have no hardware affected by this issue, the debug output was
just there to confirm we were catching the cases we expected to. Looks
like its working.

> If not, it would be better to recover somehow - presumably by blacklisting
> this machine or by falling back to a different time source.  Possible?

Don't think that's necessary. We can probably #ifdef DEBUG_PMTMR the
printks.

thanks
-john


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/