Re: swsusp does not stop DMA properly during resume

[Andrew Morton]

Pavel Machek <pavel@xxxxxxx> wrote:
>
> Hi!
> 
> > > I _think_ what this patch is doing is suspending all devices from within
> > > the boot kernel before starting into the resumed kernel.  Is this correct?
> > > 
> > > > +	update_screen(fg_console);	/* Hmm, is this the problem? */
> > > 
> > > Cryptic comment.  To what "problem" does this refer?
> > 
> > Note that you should make sure all calls to update_screen (among others)
> > are guarded by the console semaphore, with my VT patch, not doing so
> > will result in WARN_ON's
> 
> Hmmm... yes, I'll need to fix that one. [Is there console semaphore in
> 2.6.1, or do I need to wait for 2.6.2 before I can do something with
> this?]

It's acquire_console_sem()/release_console_sem().

I'll change the patch.  Could you please test it all in next -mm, let me
know?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/