Re: [PATCH] sisfb update 2.6.1

[Andrew Morton]

Thomas Winischhofer <thomas@xxxxxxxxxxxxxxxx> wrote:
>
> > It still has floating point stuff in sis_init().  Could you please
>  > review, integrate and test the below patch?
> 
>  sis_init()? You probably mean sis/init.c?
> 
>  Anyway: Irrelevant. This code part isn't even being compiled for the 
>  linux kernel (See line 4304 - #ifdef LINUX_XF86).

Well darn, that patch fixed the wrong bit and we still have float in there.
allmodconfig doesn't pick this up.


drivers/built-in.o: In function `sisfb_do_set_var':
//drivers/video/sis/sis_main.c:654: undefined reference to `__floatsidf'
...
drivers/built-in.o: In function `sisfb_init':
//drivers/video/sis/sis_main.c:4450: undefined reference to `__floatsidf'

Search for "1E12" in sis_main.c


Here's the patch which adds -msoft-float to the kernel build, which picks
up these things.

--- 25/arch/i386/Makefile~use-soft-float	2004-01-07 10:36:36.000000000 -0800
+++ 25-akpm/arch/i386/Makefile	2004-01-07 10:36:36.000000000 -0800
@@ -19,7 +19,7 @@ LDFLAGS		:= -m elf_i386
 OBJCOPYFLAGS	:= -O binary -R .note -R .comment -S
 LDFLAGS_vmlinux :=
 
-CFLAGS += -pipe
+CFLAGS += -pipe -msoft-float
 
 # prevent gcc from keeping the stack 16 byte aligned
 CFLAGS += $(call check_gcc,-mpreferred-stack-boundary=2,)

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/