Re: logic error in radeonfb.

[Benjamin Herrenschmidt]

On Fri, 2004-01-23 at 17:35, davej@xxxxxxxxxx wrote:
> Looks like another instance of a ! in the wrong place.

Ohh, and _oooold_ bug fixed a long time ago in 2.4. There may actually
be another occurence of this one elsewhere iirc. I'll check that. Note
that this code is powermac specific anyway and that old radeonfb doesn't
work very well on a lot of powermacs, so it's not very urgent. The new
radeonfb which has that fixed for a long time will get in along with
the fbdev updates as soon as I'm finished cleaning them up.

Ben.

>     Dave
> 
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/radeonfb.c linux-2.5/drivers/video/radeonfb.c
> --- bk-linus/drivers/video/radeonfb.c	2004-01-21 15:58:42.000000000 +0000
> +++ linux-2.5/drivers/video/radeonfb.c	2004-01-21 17:48:54.000000000 +0000
> @@ -2319,7 +2319,7 @@ static int radeon_set_backlight_enable(i
>  	lvds_gen_cntl |= (LVDS_BL_MOD_EN | LVDS_BLON);
>  	if (on && (level > BACKLIGHT_OFF)) {
>  		lvds_gen_cntl |= LVDS_DIGON;
> -		if (!lvds_gen_cntl & LVDS_ON) {
> +		if (!(lvds_gen_cntl & LVDS_ON)) {
>  			lvds_gen_cntl &= ~LVDS_BLON;
>  			OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
>  			(void)INREG(LVDS_GEN_CNTL);
-- 
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/