Re: logic error in XFS

[Måns Rullgård]

davej@xxxxxxxxxx writes:

> Yet another misplaced ! by the looks..

Sure looks like it.  When is this code encountered?

> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
> --- bk-linus/fs/xfs/xfs_log_recover.c	2003-10-09 01:01:24.000000000 +0100
> +++ linux-2.5/fs/xfs/xfs_log_recover.c	2004-01-14 07:06:40.000000000 +0000
> @@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
>  		case XFS_LI_BUF:
>  		case XFS_LI_6_1_BUF:
>  		case XFS_LI_5_3_BUF:
> -			if ((!flags & XFS_BLI_CANCEL)) {
> +			if (!(flags & XFS_BLI_CANCEL)) {
>  				xlog_recover_insert_item_frontq(&trans->r_itemq,
>  								itemq);
>  				break;

-- 
Måns Rullgård
mru@xxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/