Re: 2.6.2-rc2-mm2
From: Tim Hockin
Date: Fri Jan 30 2004 - 15:19:42 EST
On Fri, Jan 30, 2004 at 11:47:01AM -0800, Andrew Morton wrote:
> > directly calling sys_ANYTHING sounds really wrong to me...
It sounded wrong to me, but it gets done ALL OVER.
> Tim, I do think it would be neater to add another entry point in sys.c for
> nfsd and just do a memcpy.
Do you prefer:
a) make a function
sys.c: ksetgroups(int gidsetsize, gid_t *grouplist)
which does the same as sys_setgroups, but without the copy_from_user()
stuff? The only user (for now, maybe ever) is nfsd.
b) make a function
sys.c: nfsd_setgroups(int gidsetsize, gid_t *grouplist)
which does the same as sys_setgroups, but without the copy_from_user()
c) make the nfsd code build a struct group_info and call
set_current_groups()
--
Tim Hockin
Sun Microsystems, Linux Software Engineering
thockin@xxxxxxx
All opinions are my own, not Sun's
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/