Re: 2.6.2-rc2-mm2

[John Stoffel]

>>>>> "Andrew" == Andrew Morton <akpm@xxxxxxxx> writes:

Andrew> Can we do d)?

Andrew> static long do_setgroups(int gidsetsize, gid_t __user *user_grouplist,
Andrew> 			gid_t *kern_grouplist)
Andrew> {
Andrew> 	gid_t groups[NGROUPS];

Call me stupid, but what if we accept the patches to increase the
number of groups, won't that make this array be huge potentially?
Shouldn't we instead do a kmalloc() using current->ngroups instead?

John
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/