Re: [PATCH] restore protections after forced fault in get_user_pages

From: Ingo Molnar
Date: Tue Feb 03 2004 - 03:30:51 EST



* Linus Torvalds <torvalds@xxxxxxxx> wrote:

> > I think this question is orthogonal to my concern about follow_page.
>
> The follow_page issue should be fixable by just marking the _page_
> dirty inside the ptrace routines. I think we do that anyway (or we'd
> already be buggy wrt perfectly normal writes).

the follow_page() issue could be handled like the 4/4 patch does it: a
repeat-until loop of manual-fault + lookup-pte (we break out of the loop
if the manual fault fails or when the lookup is successful). The race
window is so small that the repeating solution is i think far superior
to artificially dirtying the pte.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/