Re: proper place for devfs_register_chrdev with pci_module_init

From: Greg KH
Date: Thu Feb 05 2004 - 10:28:51 EST


On Thu, Feb 05, 2004 at 07:42:06AM -0500, Richard B. Johnson wrote:
> On Wed, 4 Feb 2004, Greg KH wrote:
>
> > On Wed, Feb 04, 2004 at 05:29:31PM -0500, Richard B. Johnson wrote:
> > >
> > > I would call pci_find_class() and continue until a NULL is returned
> > > or my vendor and device are returned in the structure.
> >
> > NOOOOO!!!!!
> >
> > Do NOT do this. Use pci_register_driver() instead. Using pci_find_*()
> > is just broken and wrong for 99% of all pci drivers.
>
> WTF? How do you find out if your board in actually in the system?
> You CANNOT load all possible modules, hoping that somebody will
> hot-plug in one of the devices a year from now.

It is interesting how all of the words in your reply seem to make real
sentances, yet those sentances have nothing to do at all with the topic
at hand.

Please stop trolling the newbies, as much fun as it may seem, it's not a
nice thing to do.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/