Re: [PATCH 2.6.2] Documentation/SubmittingPatches

From: Arthur Othieno
Date: Thu Feb 05 2004 - 14:12:41 EST


On Wed, Feb 04, 2004 at 11:23:03PM -0800, Bryan Whitehead wrote:
>
> I've been trying to get my feet wet by submitting trivial patchs to
> various maintainers and the responses have been, "your not submiting
> you patches correctly". It seems most developers/maintainers want a
> diff done like this:
>
> cd /source-tree
> diff -u linux-2.6.2/FileToPatch.orig linux-2.6.2/FileToPatch
>
> instead of the "SubmitingPatches" document way:
> cd /source-tree/linux-2.6.2
> diff -u FileToPatch.orig FileToPatch
>
> It would be _great_ if the Documentation was more accurate to the taste
> of developers/maintainers...
>
> If the SubmittingPatches document is correct, then just toss this patch
> out because this won't be submitted right... ;)
>
> --- linux-2.6.2/Documentation/SubmittingPatches.orig 2004-02-04 22:57:55.818563016 -0800
> +++ linux-2.6.2/Documentation/SubmittingPatches 2004-02-04 23:01:28.799185040 -0800
> @@ -33,13 +33,15 @@
>
> To create a patch for a single file, it is often sufficient to do:
>
> - SRCTREE= /devel/linux-2.4
> + SRCTREE= /devel/
> + SRCDIR= linux-2.4
> MYFILE= drivers/net/mydriver.c

Might as well change this to `linux-2.6' altogether.

Arthur
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/