Re: [patch] 2.6.2-mm1: fix warning introduced by input-2wheel-mouse-fix

[Zephaniah E. Hull]

On Fri, Feb 06, 2004 at 12:12:27AM +0100, Adrian Bunk wrote:
> On Thu, Feb 05, 2004 at 09:58:18AM -0800, John Cherry wrote:
> >...
> > The nit warnings that sprung up in the defconfig builds are...
> >...
> > drivers/usb/input/hid-input.c: In function `hidinput_hid_event':
> > drivers/usb/input/hid-input.c:436: warning: suggest parentheses around
> > && within ||
> >...
> 
> This one's easy to fix:
> 
> --- linux-2.6.2-mm1/drivers/usb/input/hid-input.c.old	2004-02-06 00:05:19.000000000 +0100
> +++ linux-2.6.2-mm1/drivers/usb/input/hid-input.c	2004-02-06 00:05:50.000000000 +0100
> @@ -433,7 +433,7 @@
>  	input_regs(input, regs);
>  
>  	if (((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_EXTRA) && (usage->code == BTN_EXTRA))
> -		|| (hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK)) {
> +		|| ((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK))) {
>  		if (value)
>  			hid->quirks |= HID_QUIRK_2WHEEL_MOUSE_HACK_ON;
>  		else
> 
> 
> Please apply

Ah hell, yes, please do apply.

*looks around for a brown paper bag*

-- 
	1024D/E65A7801 Zephaniah E. Hull <warp@xxxxxxxxxxxxxxxx>
	   92ED 94E4 B1E6 3624 226D  5727 4453 008B E65A 7801
	    CCs of replies from mailing lists are requested.

On Sat, 13 Jul 2002, Alexander Viro wrote:
>
> So I'd just do
>
> vi fs/dcache.c -c '/|= DCACHE_R/d|/nr_un/pu|<|x'
>
> and be done with that.  Linus?

Done.

For future reference - don't anybody else try to send patches as vi
scripts, please. Yes, it's manly, but let's face it, so is bungee-jumping
with the cord tied to your testicles.

                Linus

Attachment: signature.asc
Description: Digital signature