Re: 2.6.3-rc3 radeonfb: Problems with new (and old) driver

From: Linus Torvalds
Date: Mon Feb 16 2004 - 17:16:49 EST




On Tue, 17 Feb 2004, Benjamin Herrenschmidt wrote:
>
> Do we want to pay the cost (in time) of a full mode set + engine reset
> on each unblank ? I could limit myself to restoring the accel engine,
> that faster, but with X also not always restoring the console mode
> properly, I'd have preferred re-setting the whole mode...

Well, on blanking, we do actually already pass in a parameter that says
"this is not a full blank, it's just a move to graphics mode". It would
make 100% sense to add the _same_ parameter to the unblank code.

That would just make the code more logical, and it should fix your
concerns, no?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/