Re: [PATCH] PSX support in input/joystick/gamecon.c

From: Peter Nelson
Date: Tue Feb 17 2004 - 01:58:53 EST


Dmitry Torokhov wrote:

Nitpick: module_param, if module is compiled in, adds a prefix to parameter

names, so the parameters will be:
gamecon.gc
gamecon.gc_2
gamecon.gc_3
gamecon.gc_psx_delay
gamecon.gc_psx_ddr

At least with PSX stuff it would be nice to drop gc_ prefix.

Hopefully my last patch submission related to this file, here's an updated one using module_param_named so the external name is just psx_ (I'm leaving the internal name as gc_psx_ just for consistency with the rest of the file).

Thanks for the feedback,
-Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/