Re: [PATCH][1/6] A different KGDB stub

From: Andrew Morton
Date: Tue Feb 17 2004 - 19:36:47 EST


Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> wrote:
>
> By my read of Andi's email, the kern_do_schedule() gunk is "I really
> don't like this change. It is completely useless because you can get the
> pt_regs as well from the stack. Please don't add it. George's stub also
> didn't need it."
>
> But I don't see how it does. But I'll look again tomorrow.

OK, thanks. That would be appreciated, if only because the sched.c and
entry.S changes have caused significant patch-conflict hassles in the past,
and they're pretty ugly.

Plus the little fact that the patch which you sent broke all other
architectures: they call schedule() from assembly code, and schedule()
ain't there any more.

I'll have a play with the patches which you sent, and if they don't break
I'll add them to -mm and I'll kludgily fix ppc64 and ia64 (if needed). Be
aware that I removed the (large amount of) trailing whitespace which they
added.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/