Re: [NFS] nfs or autofs related hangs

[Ian Kent]

On Tue, 17 Feb 2004, Rusty Russell wrote:

> On Mon, 16 Feb 2004 09:13:55 +0800 (WST)
> Ian Kent <raven@xxxxxxxxxx> wrote:
> 
> > On Sun, 15 Feb 2004, Rusty Russell wrote:
> > > Is this __cacheline_aligned_in_smp really required?
> > 
> > I must admit I put this together without much thought with a "cut and 
> > paste".
> > 
> > But, please tell me. I'm not entirely clear on what conditions I 
> > should be concerned about blowing the cache.
> 
> You should usually try to declare the spinlock near the things it protects, in
> the hope that they'll be in the same cacheline.  If we blow 128 bytes for
> every spinlock, things will get slower, not faster.

Thanks. I'll take it out.

Do you mean near to the storage declaration. This lock is used in three 
places in the module within it's declared. Near the begining, the middle 
and near the end.

Ian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/