Re: Linux 2.6.3-rc4

[Linus Torvalds]

On Wed, 18 Feb 2004, Roman Zippel wrote:
> 
> Linus, I think that's the best solution for now. I have to think a bit
> more about the problem, how a boolean symbol should select a tristate
> symbol.

Hmm.. I already rewrote it the way you suggested earlier, ie like the 
appended. A quick (but ny no means exhaustive) test implied that 
this works fine too.

		Linus

----
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1646  -> 1.1647 
#	drivers/video/Kconfig	1.38    -> 1.39   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/17	torvalds@xxxxxxxxxxxxx	1.1647
# Fix the dependency chain for I2C_ALGOBIT from the FB
# drivers that need it. 
# 
# This allows us to have I2C as a module iff the FB driver
# that needs it is a module.
# --------------------------------------------
#
diff -Nru a/drivers/video/Kconfig b/drivers/video/Kconfig
--- a/drivers/video/Kconfig	Tue Feb 17 18:57:36 2004
+++ b/drivers/video/Kconfig	Tue Feb 17 18:57:36 2004
@@ -462,6 +462,7 @@
 config FB_MATROX
 	tristate "Matrox acceleration"
 	depends on FB && PCI
+	select I2C_ALGOBIT if FB_MATROX_I2C
 	---help---
 	  Say Y here if you have a Matrox Millennium, Matrox Millennium II,
 	  Matrox Mystique, Matrox Mystique 220, Matrox Productiva G100, Matrox
@@ -549,7 +550,6 @@
 config FB_MATROX_I2C
 	tristate "Matrox I2C support"
 	depends on FB_MATROX && I2C
-	select I2C_ALGOBIT
 	---help---
 	  This drivers creates I2C buses which are needed for accessing the
 	  DDC (I2C) bus present on all Matroxes, an I2C bus which
@@ -627,6 +627,7 @@
 config FB_RADEON
 	tristate "ATI Radeon display support"
 	depends on FB && PCI
+	select I2C_ALGOBIT if FB_RADEON_I2C
 	help
 	  Choose this option if you want to use an ATI Radeon graphics card as
 	  a framebuffer device.  There are both PCI and AGP versions.  You
@@ -645,7 +646,6 @@
 config FB_RADEON_I2C
 	bool "DDC/I2C for ATI Radeon support"
 	depends on FB_RADEON && I2C
-	select I2C_ALGOBIT
 	default y
 	help
 	  Say Y here if you want DDC/I2C support for your Radeon board. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/