Re: ppc suspend rewrite using inline.

[Benjamin Herrenschmidt]

On Wed, 2004-02-18 at 18:35, Hugang wrote:
> Hi Ben:
> 
> I has finished rewriten the suspend code by inline, The swsusp2 works
> fine without any problem, But pmdisk can't works, The problem that's,
> when resume the current is not same as suspend.

I don't understand why you write. Looking at your code, I don't see
the point. By mixing C and assembly the way you do, and using those
horrible inline asm constructs, you are basically making the code
worse, less readable, and prone for bugs. I don't think you should
even try going into that direction, it makes no sense.

> I think the code can reuse by sleep.

Same

> I think turn off mmu copyback page is important, but I has looked x86
> resume code, it do not. 

Same

> Please take a look.

Please try to be clear.

> thanks.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/